----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112717 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 54) <https://reviews.apache.org/r/39584/#comment173203> the current function is not os::rmdir. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 64) <https://reviews.apache.org/r/39584/#comment173202> What does "Previous" mean here? Should it be "Parent"? 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 87) <https://reviews.apache.org/r/39584/#comment173204> os::rmdir is not the right func name. Also, "found it was not a valid directory" does not make sense because we only hit here when it's not a directory. 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 96) <https://reviews.apache.org/r/39584/#comment173205> os::rmdir - Yi Sun On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39584/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `os::rmdir.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > e738cdbf5846950c475c159fb9a770acc45159f5 > > Diff: https://reviews.apache.org/r/39584/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
