----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42093/ -----------------------------------------------------------
(Updated Jan. 8, 2016, 11:41 p.m.) Review request for mesos, Ben Mahler and Timothy Chen. Summary (updated) ----------------- Added proper handling of `None()` in the `CfsFilter`. Repository: mesos Description (updated) ------- Added proper handling of `None()` in the `CfsFilter`. Previously, this test assumed that `cgroups::hierarchy("cpu")` would either return `Some()` or an `Error()`. However, the call may return `None()`, and this must be handled properly. Diffs ----- src/tests/environment.cpp 9d05630661bf6f20dbb492a27811933f65f3d14e Diff: https://reviews.apache.org/r/42093/diff/ Testing ------- `sudo GTEST_FILTER="*CFS_*" bin/mesos-tests.sh` on Ubuntu 14.04, first with the 'cpu' hierarchy mounted, then without the hierarchy mounted. When properly mounted, the tests will run. When unmounted, the correct error message is displayed corresponding to a `cgroups::hierarchy("cpu")` return value of `None()`, and the tests are filtered out. Thanks, Greg Mann