> On Dec. 30, 2015, 8:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1302 > > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1302> > > > > If framework has reserved.statless resources, allocator should not > > dispatch it as ALLOCATION_SLACK. > > Klaus Ma wrote: > @Joseph, I can not remenber where did you append your comments about this > topic; but it seems you're OK to offer both `stateless.reserved` & > `ALLOCATION_SLACK` of the same role, right? But how framework developer > distinguish `stateless.reserved` & `ALLOCATION_SLACK` of its? If it launch > task in `ALLOCATION_SLACK` and `stateless.reserved`, the task in > `ALLOCATION_SLACK` was terminated immediately; it just increases overhead of > cluster instead of resource utilization. > > Joseph Wu wrote: > There's something about this in the design doc. > > The summary is: Meta-frameworks may benefit from receiving allocation > slack from itself. > > Klaus Ma wrote: > OK, would you help to update the design doc? There's comments that: > > NOTE: We need to be careful not to offer the same resources (as reserved > resources and as revocable resources) to the same framework. This could > presumably happen if a Lender Framework also accepts revocable resources. > > Guangya Liu wrote: > I've already handled this case here: When sending offers, the allocation > slack resources in the offer need to exclude all allocated stateless reserved > resources and allocated allocation slack resources.
I think current code did not handle this case; if a Lender framekwork accepts revocable resources, the framework's `stateless.reserved` resource & allocation slack from that `stateless.reserved` will send to that famework; so "offer the same resources (as reserved resources and as revocable resources) to the same framework". - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review112309 ----------------------------------------------------------- On Jan. 8, 2016, 2:55 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 2:55 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > There are three patches handling the allocator part: > 1) This patch handles send offer, add slave and quota integration test. > 2) https://reviews.apache.org/r/41847/ Handles the case of update slave. > 3) https://reviews.apache.org/r/41791/ Handles the case of dynamic > reservations. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
