----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/ -----------------------------------------------------------
Review request for mesos and Till Toenshoff. Bugs: MESOS-3082 https://issues.apache.org/jira/browse/MESOS-3082 Repository: mesos Description ------- Virtual machines may not always support 'CPU performance counters'. Tests trying to collect to 'cycle' value of 'perf' will fail under these circumstances. This will be avoided by disabling these tests if 'perf' hardware events are not available. Diffs ----- src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 Diff: https://reviews.apache.org/r/42197/diff/ Testing ------- `sudo ./bin/mesos-tests.sh --gtest_filter="-*ROOT_CGROUPS_Perf:*ROOT_CGROUPS_Sample:*ROOT_CGROUPS_UserCgroup:*CGROUPS_ROOT_PerfRollForward:*ROOT_Sample"` in a VM without 'CPU performance counters'. This doesn't run any tests, as expected. Thanks, Jan Schlicht