> On Jan. 20, 2016, 7:41 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 539-541 > > <https://reviews.apache.org/r/42516/diff/1/?file=1201989#file1201989line539> > > > > I think that you may also want some test cases to verify port mapping > > plus user defined network.
We agree that currently it seems we can't add a unit-test - Ezra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115372 ----------------------------------------------------------- On Jan. 20, 2016, 12:25 p.m., Ezra Silvera wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42516/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 12:25 p.m.) > > > Review request for mesos and TimothyIL TimothyIL. > > > Bugs: MESOS-4369 > https://issues.apache.org/jira/browse/MESOS-4369 > > > Repository: mesos > > > Description > ------- > > Signed-off-by: Ezra Silvera <e...@il.ibm.com> > > Review: https://reviews.apache.org/r/42549 > > > Diffs > ----- > > include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b > include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd > src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e > > Diff: https://reviews.apache.org/r/42516/diff/ > > > Testing > ------- > > Using Swarm running on Mesos create a network with "docker network create > --driver=bridge myNetwork" and then create a container on that network: > "docker run --net=myNetwork...." > > > Thanks, > > Ezra Silvera > >
