----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115472 -----------------------------------------------------------
Ship it! src/slave/slave.cpp (lines 369 - 372) <https://reviews.apache.org/r/42474/#comment176449> You may want to print the error message here (will be useful for triaging). ``` Try<Nothing> mkdir = os::mkdir(...); if (mkdir.isError()) { EXIT(1) << "...: " << mkdir.error(); } ``` - Jie Yu On Jan. 20, 2016, 7:15 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42474/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 7:15 p.m.) > > > Review request for mesos, Jie Yu and Michael Park. > > > Bugs: MESOS-4403 > https://issues.apache.org/jira/browse/MESOS-4403 > > > Repository: mesos > > > Description > ------- > > Create disk paths based on 'DiskInfo.Source' if the type is 'PATH' > and the directory does not yet exist. > > > Diffs > ----- > > src/slave/slave.cpp bd7fe03f8a8b07c6201db2f876f4f9cd7dc337cf > > Diff: https://reviews.apache.org/r/42474/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > >
