----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review116670 -----------------------------------------------------------
Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:56 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42877/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 6:56 a.m.) > > > Review request for mesos, Greg Mann and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > For consistency, we should do `driver.stop(); driver.join();` if a > `MesosSchedulerDriver` has been started by the unit test. The destructor for > `MesosSchedulerDriver` will do something _similar_, so the consequence of > omitting these calls is not dire, but it seems safer to be consistent between > all the test cases. > > > Diffs > ----- > > src/tests/executor_http_api_tests.cpp > 36a042ed103271ca873450236f39a8152fbbf07e > src/tests/oversubscription_tests.cpp > 6f43103e81303015fb614653e3bfece55009d1bf > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > src/tests/scheduler_event_call_tests.cpp > bd8920fa9d5475e5f6533c8424ebff1588bfe645 > src/tests/scheduler_http_api_tests.cpp > 9eb1de7d9541395b92b951f0fe0ddbb2f219fe30 > src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead > > Diff: https://reviews.apache.org/r/42877/diff/ > > > Testing > ------- > > make check > > Note that adding the `driver.stop(); driver.join();` calls to two of the > slave tests requires adding an extra shutdown expectation to avoid a GMock > warning. > > > Thanks, > > Neil Conway > >
