----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review117116 -----------------------------------------------------------
Thanks for fixing this! Is there a ticket with the issue? I will do a more complete review tomorrow. src/docker/executor.cpp (line 135) <https://reviews.apache.org/r/43015/#comment178200> I am not sure why we are printing this, but shouldn't we at least check for errors on os::shell? src/slave/containerizer/docker.cpp (line 522) <https://reviews.apache.org/r/43015/#comment178201> Just for my understanding: We assume the docker containerizer to only run on linux? Maybe we could add a short comment. src/slave/containerizer/docker.cpp (line 992) <https://reviews.apache.org/r/43015/#comment178202> This looks like it could fit in a single line. - Joerg Schad On Jan. 30, 2016, 5:25 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2016, 5:25 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920 > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9 > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
