----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43015/#review119208 -----------------------------------------------------------
src/slave/containerizer/docker.cpp (line 505) <https://reviews.apache.org/r/43015/#comment180480> What about add `containerId` in the log message? src/tests/containerizer/docker_containerizer_tests.cpp (line 3149) <https://reviews.apache.org/r/43015/#comment180482> s/by default/the default There are indeed patches trying to update all `by default` to `the default`: https://reviews.apache.org/r/42689/ src/tests/containerizer/docker_containerizer_tests.cpp (line 3160) <https://reviews.apache.org/r/43015/#comment180485> Why not `ASSERT_EQ(1u, offers2.get().size());`? This seems more accurate - Guangya Liu On 二月 14, 2016, 8:38 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43015/ > ----------------------------------------------------------- > > (Updated 二月 14, 2016, 8:38 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3413 > https://issues.apache.org/jira/browse/MESOS-3413 > > > Repository: mesos > > > Description > ------- > > Fixed persistent volumes with docker tasks. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 77a50d80179672cf3c270cbdd7fa003c7d9ad6f3 > src/slave/containerizer/docker.cpp ed1c9a551f03a37d572470e4c495f5df834198cc > src/tests/containerizer/docker_containerizer_tests.cpp > 645bdcf095145097d8b8c65d592c787417883145 > > Diff: https://reviews.apache.org/r/43015/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
