> On Feb. 1, 2016, 9:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 454-455 > > <https://reviews.apache.org/r/42618/diff/3/?file=1227395#file1227395line454> > > > > In fact, i think we should add a helper in src/linux/cgroup.hpp (like > > we did for other cgroups controls like cpu.shares, etc.) > > > > ``` > > Try<Nothing> cgroups::net_cls::classid(uint32_t classid) > > ```
Will do. Will create a separate patch and make this dependent on the new patch. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117275 ----------------------------------------------------------- On Jan. 31, 2016, 8:06 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42618/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 8:06 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > The `NetClsHandleMgr` will be responsible for keeping track of the net_cls > handles that will be used by the net_cls cgroup subsystem. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42618/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >
