> On Feb. 1, 2016, 8:14 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 499-503 > > <https://reviews.apache.org/r/42618/diff/3/?file=1227395#file1227395line499> > > > > You should do this after the cgroup has been destroyed.
Makes sense. Planning to convert the lamdba being used in the defer for cleanup into a function, since we are adding more logic to the Lambda now. Hope that's fine? - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117243 ----------------------------------------------------------- On Jan. 31, 2016, 8:06 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42618/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2016, 8:06 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > The `NetClsHandleMgr` will be responsible for keeping track of the net_cls > handles that will be used by the net_cls cgroup subsystem. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42618/diff/ > > > Testing > ------- > > make and make check > > > Thanks, > > Avinash sridharan > >