----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Repository: mesos Description ------- Fixes [MESOS-4370] Diffs ----- src/docker/docker.cpp a831726 Diff: https://reviews.apache.org/r/43093/diff/ Testing ------- This patch will first query the docker API for the HostConfig.NetworkMode, which is populated with the network name. (Essentially what was passed in --net <name> to the docker run command). This name is then used as a key in NetworkSettings.Networks.<name>.IPAddress to get the IP address that is currently in use by the container. It appears that even though the docker API has been set up to allow for multiple networks, our testing has indicated that it's still only applying one network to the container (the last one via the --net argument on the run line). I can only speculate that the docker API will change again in the near future, but I can't speculate how, so at least this fixes the problem as it stands right now. Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04 Thanks, Travis Hegner
