----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review117600 -----------------------------------------------------------
src/docker/docker.cpp (line 316) <https://reviews.apache.org/r/43093/#comment178841> Seems use a variable to store the string `"NetworkSettings.Networks." + networkMode + ".IPAddress"` would be better. And that we could continue use that in the following code. src/docker/docker.cpp (line 321) <https://reviews.apache.org/r/43093/#comment178843> Should we try got `"NetworkSettings.IPAddress"` to compatiable old api if could not the by new api spec. - haosdent huang On Feb. 2, 2016, 10:06 p.m., Travis Hegner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43093/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 10:06 p.m.) > > > Review request for mesos and Kapil Arya. > > > Bugs: MESOS-4370 > https://issues.apache.org/jira/browse/MESOS-4370 > > > Repository: mesos > > > Description > ------- > > Fixes [MESOS-4370] > > > Diffs > ----- > > src/docker/docker.cpp a831726 > > Diff: https://reviews.apache.org/r/43093/diff/ > > > Testing > ------- > > This patch will first query the docker API for the HostConfig.NetworkMode, > which is populated with the network name. (Essentially what was passed in > --net <name> to the docker run command). This name is then used as a key in > NetworkSettings.Networks.<name>.IPAddress to get the IP address that is > currently in use by the container. > > It appears that even though the docker API has been set up to allow for > multiple networks, our testing has indicated that it's still only applying > one network to the container (the last one via the --net argument on the run > line). I can only speculate that the docker API will change again in the near > future, but I can't speculate how, so at least this fixes the problem as it > stands right now. > > Tested and working with Docker 1.9.1, Mesos 0.27.0, on Ubuntu 14.04. > > > Thanks, > > Travis Hegner > >
