----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43036/#review117449 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (lines 840 - 841) <https://reviews.apache.org/r/43036/#comment178631> Does this compile? Should that be: ``` ContainerConfig::Docker* docker = containerConfig.mutable_docker(); docker->mutable_manifest()->CopyFrom( provisionInfo->dockerManifest.get()); ``` src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 78 - 79) <https://reviews.apache.org/r/43036/#comment178632> No need for this. src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 81 - 83) <https://reviews.apache.org/r/43036/#comment178633> I would move this up as the first check so that you don't have to do `executorInfo.has_container()` in later checks - Jie Yu On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43036/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 5:18 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4517 > https://issues.apache.org/jira/browse/MESOS-4517 > > > Repository: mesos > > > Description > ------- > > Plugged in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43036/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
