> On Jan. 29, 2016, 1:25 a.m., Qian Zhang wrote: > > docs/reservation.md, lines 80-81 > > <https://reviews.apache.org/r/42755/diff/1/?file=1220234#file1220234line80> > > > > I understand the two reservations with different labels will not be > > combined. But what about the two reservation with same label? Do we need to > > describe its behavior here too? > > > > I think the latter is a bit complex, e.g., one reservation made by > > framework with a label and another reservation made by operator with the > > same label. Will we combine them into one reservation? In this case, the > > principle of the two reservations could be different, right? So we will end > > up with two separate reservations with same label?
Hi Qian -- good points. If two reservations have different labels, they will not be merged. Similarly, if two reservations have the same label but different principals or roles, they will also not be merged. You basically need _all_ the metadata about two reservations (role, slave-id, principal, labels, etc.) to be the same for them to be merged. Your point made me realize we don't have unit tests for the case where two reservations have the same role but different principals -- I opened https://issues.apache.org/jira/browse/MESOS-4590 to track that. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/#review116861 ----------------------------------------------------------- On Feb. 3, 2016, 5:51 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42755/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 5:51 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added documentation for labeled reserved resources. > > > Diffs > ----- > > docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 > > Diff: https://reviews.apache.org/r/42755/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
