----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43003/#review117092 -----------------------------------------------------------
include/mesos/appc/spec.proto (line 31) <https://reviews.apache.org/r/43003/#comment178162> s/AppcImageManifest/ImageManifest You've already had appc in the namespace. src/Makefile.am (line 153) <https://reviews.apache.org/r/43003/#comment178159> You need to create a PROTO for APPC_SPEC src/Makefile.am (lines 405 - 413) <https://reviews.apache.org/r/43003/#comment178161> You need to do the similar to appc spec files as well. src/Makefile.am (line 1012) <https://reviews.apache.org/r/43003/#comment178160> You need to add APPC_SPEC_PROTO here src/slave/containerizer/mesos/provisioner/appc/spec.cpp (line 13) <https://reviews.apache.org/r/43003/#comment178945> Let's move this file to src/appc/spec.cpp like we did for docker spec files. - Jie Yu On Jan. 30, 2016, 2:13 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43003/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2016, 2:13 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4564 > https://issues.apache.org/jira/browse/MESOS-4564 > > > Repository: mesos > > > Description > ------- > > This change enables clean separation of concerns and keep appc messages > loosely coupled from other mesos messages. > > > Diffs > ----- > > include/mesos/appc/spec.proto PRE-CREATION > include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 > src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 > src/slave/containerizer/mesos/provisioner/appc/paths.hpp > dfeb3ffad2503444854c7830ee1b613ce076dfd8 > src/slave/containerizer/mesos/provisioner/appc/paths.cpp > 94df5b2007d2988189e9c973b2348697a534ab7e > src/slave/containerizer/mesos/provisioner/appc/spec.hpp > d4fd8cbfd5668da9ce4ac86baaadf42945c5abbd > src/slave/containerizer/mesos/provisioner/appc/spec.cpp > 324cdfec3766da4a8e324378a6e413477fa2b5d9 > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 73c4df858a70da3d4cc4a1cb15092165f6ff8fe4 > src/tests/containerizer/provisioner_appc_tests.cpp > e3d08d9e49df93d5290099c8bfd917f60c93e51b > > Diff: https://reviews.apache.org/r/43003/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >