----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review117730 -----------------------------------------------------------
src/tests/reservation_endpoints_tests.cpp (lines 752 - 757) <https://reviews.apache.org/r/42754/#comment179012> Since the unreserve operation would rescind resources as necessary, I don't think we need to do this. Is this not the case? src/tests/resources_tests.cpp (line 35) <https://reviews.apache.org/r/42754/#comment179013> Should come after `std` using declarations. src/tests/resources_tests.cpp (line 1650) <https://reviews.apache.org/r/42754/#comment179015> `s/AdditionDynamicallyReserved/AdditionDynamicallyReservedWithoutLabels/` src/tests/resources_tests.cpp (line 1666) <https://reviews.apache.org/r/42754/#comment179009> `s/AdditionDynamicallyReservedWithLabels/AdditionDynamicallyReservedWithSameLabels/`? src/tests/resources_tests.cpp (line 1708) <https://reviews.apache.org/r/42754/#comment179016> Weird that we didn't have `SubtractionStaticallyReserved` and `SubtractionDynamicallyReserved` before. Can we take this opportunity to sync `Addition` and `Subtraction`? or do you think there's a good reason to keep them conflated in this case? As written, it looks like we're expecting the correct portions (statically reserved from `r1` and dynamically reserved from `r2`) of `total` to be subtracted by `r7` and `r8`. I'd ok with keeping this pattern, and if we were to do that, I think we should add the labeled states into the `total` and expect the correct portions of them to be subtracted. What do you think? - Michael Park On Feb. 3, 2016, 11:32 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42754/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 11:32 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4479 > https://issues.apache.org/jira/browse/MESOS-4479 > > > Repository: mesos > > > Description > ------- > > Labels are free-form key-value pairs that can be used to associate > metadata with reserved resources. > > > Diffs > ----- > > include/mesos/mesos.proto 194750e92020753e60154083a47bdc3398d31466 > include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 > include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 > include/mesos/v1/mesos.proto 1102bbc92f46f97c1915c03a71c7cf829003e0ed > src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 > src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 > src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a > src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 > src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 > > Diff: https://reviews.apache.org/r/42754/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
