----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review118506 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/type_utils.hpp (line 71) <https://reviews.apache.org/r/42754/#comment179765> We should keep the 2 newlines here. There are other parts that need 2 lines also, for example between `bool operator!=(const TaskStatus& left, const TaskStatus& right);` and `inline bool operator==(const ContainerID& left, const ContainerID& right)`. src/common/resources.cpp (lines 1494 - 1500) <https://reviews.apache.org/r/42754/#comment179768> ``` stream << label.key(); if (label.has_value()) { stream << ": " << label.value(); } if (i + 1 < labels.labels().size()) { stream << ", "; } ``` Same in the v1 version. src/tests/mesos.hpp (lines 494 - 495) <https://reviews.apache.org/r/42754/#comment179766> Newline here src/tests/reservation_endpoints_tests.cpp (line 743) <https://reviews.apache.org/r/42754/#comment179759> `s/offerResources/offeredResources/`? here and below - Michael Park On Feb. 5, 2016, 2:19 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42754/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 2:19 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4479 > https://issues.apache.org/jira/browse/MESOS-4479 > > > Repository: mesos > > > Description > ------- > > Labels are free-form key-value pairs that can be used to associate > metadata with reserved resources. > > > Diffs > ----- > > include/mesos/mesos.proto 5d1a20b4ff647f43701a353472b56a4b74b6bbc3 > include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a111154411 > include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 > include/mesos/v1/mesos.proto 415a20d9f3385e9627635dd89d78c58d03e3c116 > src/common/resources.cpp 588a279c3cdebbeb58047bfbff5e78a42f53fc13 > src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89 > src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a > src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4 > src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7 > > Diff: https://reviews.apache.org/r/42754/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
