> On Feb. 5, 2016, 5:17 a.m., Ben Mahler wrote: > > support/generate-endpoint-help.py, lines 225-227 > > <https://reviews.apache.org/r/43220/diff/1/?file=1233070#file1233070line225> > > > > Do you need the empty check? Also I think we've been doing `if > > new_name` in our python style.
Unfortunately, I do need the empty check because runing join() with an empty string at the end produces an extra, unwanted "/" - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/#review117972 ----------------------------------------------------------- On Feb. 5, 2016, 3:30 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43220/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 3:30 a.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. > > > Bugs: MESOS-3831 > https://issues.apache.org/jira/browse/MESOS-3831 > > > Repository: mesos > > > Description > ------- > > Invoke this script from anywhere within the mesos source tree > (including in the build directory) to autogenerate documentation for > all endpoint strings and install them into the docs/endpoint folder. > In a subsequent commit we commit all of these autogenerated files back > to the source repo and add a link in home.md to find them. > > > Diffs > ----- > > support/generate-endpoint-help.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43220/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
