----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43220/#review118212 -----------------------------------------------------------
Ship it! Thanks! I made some minor comments but took care of those for you prior to committing. support/generate-endpoint-help.py (lines 35 - 37) <https://reviews.apache.org/r/43220/#comment179430> I noticed mixed use of single quotes and double quotes, any method to the madness? support/generate-endpoint-help.py (lines 46 - 47) <https://reviews.apache.org/r/43220/#comment179431> Seems simpler to just append \n here and use a regular string literal? support/generate-endpoint-help.py (lines 77 - 93) <https://reviews.apache.org/r/43220/#comment179458> Could we make the line wrapping formatting consistent here? - Ben Mahler On Feb. 8, 2016, 7:06 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43220/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 7:06 a.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. > > > Bugs: MESOS-3831 > https://issues.apache.org/jira/browse/MESOS-3831 > > > Repository: mesos > > > Description > ------- > > Invoke this script from anywhere within the mesos source tree > (including in the build directory) to autogenerate documentation for > all endpoint strings and install them into the docs/endpoint folder. > In a subsequent commit we commit all of these autogenerated files back > to the source repo and add a link in home.md to find them. > > > Diffs > ----- > > support/generate-endpoint-help.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43220/diff/ > > > Testing > ------- > > Ran and generated files from it. Then rebuilt the website and verified that > everything looked as it should. > > > Thanks, > > Kevin Klues > >
