> On Feb. 18, 2016, 7:41 p.m., Kevin Klues wrote: > > support/generate-endpoint-help.py, lines 47-53 > > <https://reviews.apache.org/r/43715/diff/2/?file=1254731#file1254731line47> > > > > I would rewrite this as: > > > > ``` > > MARKDOWN_HEADER = ( > > """<!--- This is an automatically generated file. DO NOT EDIT! ---> > > > > --- > > title: %s > > layout: documentation > > --- > > """ > > ) > > ``` > > > > (Notice the %s in there...) > > > > Then modify how this is used down below (as demonstrated in a follow up > > comment) > > Abhishek Dasgupta wrote: > Hi Kevin, > First line of the markdown file needs to be: > --- > title: %s > layout: documentation > --- > Otherwise, title does not appear in the generated HTML. So I put <!--- > This is an automatically generated file. DO NOT EDIT! ---> after title and > layout declaration. Is it okay?
Yeah, of course. That makes sense. Seems like a weird requirement, but if that's how it has to be, that's how it has to be, I guess. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43715/#review119678 ----------------------------------------------------------- On Feb. 18, 2016, 8:32 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43715/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 8:32 p.m.) > > > Review request for mesos, Kevin Klues and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Title for endpoint documentation. > > > Diffs > ----- > > support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 > > Diff: https://reviews.apache.org/r/43715/diff/ > > > Testing > ------- > > This is the patch for support/generate-endpoint-help.py to include the > generated files with titles. > Tested using "rake dev" on a live site. > > > Thanks, > > Abhishek Dasgupta > >
