-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119893
-----------------------------------------------------------


Fix it, then Ship it!




The summary and description will need to change, but other than that, and the 
comment below, things look good.


support/generate-endpoint-help.py 
<https://reviews.apache.org/r/43715/#comment181285>

    Actually, I was wrong, when I pull down locally, all of these newlines are 
removed (and they sbouldn't be).
    
    Can you patch things up to reinsert these newlines? If I had commit rights, 
I would just make this trivial change myself before pushing back to master. 
Since I don't though, it would be good to get everything as clean as possible 
before a shepherd takes over.
    
    Other than that, everything looks good now.


- Kevin Klues


On Feb. 19, 2016, 12:04 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the 
> generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to