> On Feb. 19, 2016, 12:23 p.m., Shuai Lin wrote: > > src/launcher/http_executor.cpp, line 776 > > <https://reviews.apache.org/r/43701/diff/1/?file=1253450#file1253450line776> > > > > Unlike unacked status updates, there could be at most one unacked task > > info, so here we don't need a map of tasks, maybe an `Option<v1::TaskInfo>` > > is enough. > > > > I know that the old `mesos::internal::ExecutorProcess` uses a map to > > store the unacked tasks, but that's because it's part of the generic > > `ExecutorDriver`, which is designed to support launching multiple tasks > > with the same executor, while the mesos cmd executor could only launch one > > task.
Agree! Will fix this soon in the patch. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43701/#review119803 ----------------------------------------------------------- On Feb. 18, 2016, 9:09 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43701/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2016, 9:09 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3558 > https://issues.apache.org/jira/browse/MESOS-3558 > > > Repository: mesos > > > Description > ------- > > Added a command executor based on the new V1 API. > > > Diffs > ----- > > docs/configuration.md 3d8236822af688a88a9f9f357c67c03d7d60fdd9 > include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 > src/Makefile.am 54ebe91643a17017c00cdbd5dfc8ce1a021579d5 > src/launcher/http_executor.cpp PRE-CREATION > src/slave/flags.hpp bd52b4f9816b271a9d2728ae6915f8e24b74d716 > src/slave/flags.cpp d4b4e5201bb3a7e8edd0ab2481328fc91cd8f974 > src/slave/slave.cpp f0be0d5bf4b853952caf06e2e262c2903d79ead3 > > Diff: https://reviews.apache.org/r/43701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
