> On Feb. 23, 2016, 12:44 a.m., Kevin Klues wrote: > > support/push-reviews.py, lines 14-15 > > <https://reviews.apache.org/r/43552/diff/2/?file=1263874#file1263874line14> > > > > I would at least pass this as a flag right now rather than jsut adding > > a TODO. Otherwise people that prefer to close with the commit message won't > > be able to use your script at all.
Not sure what you mean by pass this as a flag? Do you mean add a command line argument to the script (--say post_to_JIRA) that is a no-op? Or do you want me to write code that speaks JIRA API? Also I don't understand why people who prefer to close with a commit message can't use this script. See my comment in the previous reply to your comment. > On Feb. 23, 2016, 12:44 a.m., Kevin Klues wrote: > > support/push-reviews.py, lines 123-125 > > <https://reviews.apache.org/r/43552/diff/2/?file=1263874#file1263874line123> > > > > Shouldn't this also be protected by the `if not options['dry_run']` > > check? The only reason was to print the 'Closing review...' irrespective of the dry run option. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review120223 ----------------------------------------------------------- On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43552/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 4:52 a.m.) > > > Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park. > > > Bugs: MESOS-3929 > https://issues.apache.org/jira/browse/MESOS-3929 > > > Repository: mesos > > > Description > ------- > > This script allows committers to push locally applied review chain to the ASF > git repo and mark the reviews as submitted. > > > Diffs > ----- > > support/push-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43552/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Vinod Kone > >
