> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote: > > support/push-reviews.py, lines 108-112 > > <https://reviews.apache.org/r/43552/diff/1/?file=1252228#file1252228line108> > > > > As we close the review, we should also post a comment to reviewboard > > with the commit message we actually pushed to master. > > > > You can use the --description flag: > > > > https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/ > > Vinod Kone wrote: > I'll make a TODO for now as committers don't currently/always set the > commit message on RB. > > Kevin Klues wrote: > I think we should add the option as a command line flag now, so that > people who like to include the commit message when closing can still take > advantage of this script. If we later decide that *everyone* should always > include the commit message, we can remove the flag and force it to be set.
I am suggesting a TODO because it needs some non-trivial code change to get it to work. `get_reviews()` currently read log line by line. Also, note that people can still put a commit message in the description by directly going to RB after running this script. So I see this script as a strict improvement to the current workflow. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/#review119507 ----------------------------------------------------------- On Feb. 22, 2016, 4:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43552/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 4:52 a.m.) > > > Review request for mesos, Artem Harutyunyan, Kevin Klues, and Michael Park. > > > Bugs: MESOS-3929 > https://issues.apache.org/jira/browse/MESOS-3929 > > > Repository: mesos > > > Description > ------- > > This script allows committers to push locally applied review chain to the ASF > git repo and mark the reviews as submitted. > > > Diffs > ----- > > support/push-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/43552/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Vinod Kone > >
