----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 -----------------------------------------------------------
Great work. Still missing a bit of context about what a SchedulerDriver is though docs/app-framework-development-guide.md (lines 131 - 133) <https://reviews.apache.org/r/43819/#comment181927> Let's be very explicit that they'll need to instantiate a MesosSchedulerDriver and call these methods on it. Probably also want to document the MesosSchedulerDriver constructors so they know how to instantiate one. docs/app-framework-development-guide.md (line 138) <https://reviews.apache.org/r/43819/#comment181924> Get rid of the `virtual` and `= 0` since that's not a part of the API that their scheduler will call. They're not implementing a new SchedulerDriver, they're just instantiating one and calling its methods. docs/app-framework-development-guide.md (lines 187 - 191) <https://reviews.apache.org/r/43819/#comment181925> Remove this from the guide since it's deprecated. - Adam B On Feb. 21, 2016, 7 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43819/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2016, 7 p.m.) > > > Review request for mesos, Adam B and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Added Scheduler-Driver API to app-framework-development-guide.md. > > > Diffs > ----- > > docs/app-framework-development-guide.md > e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d > > Diff: https://reviews.apache.org/r/43819/diff/ > > > Testing > ------- > > Viewed via gist (https://gist.github.com/joerg84/b4bf279a55e1b62051e6) and > via docker website container. > > > Thanks, > > Joerg Schad > >
