> On Feb. 23, 2016, 5:21 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, line 334 > > <https://reviews.apache.org/r/43855/diff/1/?file=1264857#file1264857line334> > > > > s/Fetches/Fetch
Since i am describing what the function does, I believe the function "fetches" the image descibes what it does the best. Having said that, I am not a grammer expert and my arms could be twisted :) - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/#review120260 ----------------------------------------------------------- On Feb. 23, 2016, 3:30 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43855/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2016, 3:30 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This change allows store to fetch an image using Appc image fetcher when an > image is not found in the cache. It also recursively fetches the dependencies > for the image. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 4b3829175f57fb9aea2478040d96f2f127cbc551 > src/tests/fetcher_cache_tests.cpp e10b3f7ebc21c8c1095564fc40f123087dcf320e > > Diff: https://reviews.apache.org/r/43855/diff/ > > > Testing > ------- > > make check; local image server. > > > Thanks, > > Jojy Varghese > >
