----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120565 -----------------------------------------------------------
src/tests/containerizer/provisioner_docker_tests.cpp (line 360) <https://reviews.apache.org/r/43960/#comment182033> Would it add value if we assert that the store does not currently have the image? Also, have assertions around the image being placed in the right dircetory? src/tests/containerizer/provisioner_docker_tests.cpp (line 365) <https://reviews.apache.org/r/43960/#comment182032> Would it make sense to name these as per their semantics? `status1` does not say a lot about them. - Jojy Varghese On Feb. 24, 2016, 6:51 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43960/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 6:51 p.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added an end-to-end test for docker registry puller. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9 > > Diff: https://reviews.apache.org/r/43960/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
