----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review121078 -----------------------------------------------------------
Fix it, then Ship it! Looks good to me. I'm assuming you didn't change anything substantial in the implementation when you moved it. It looks the same to me. src/Makefile.am (lines 630 - 631) <https://reviews.apache.org/r/43863/#comment182669> Do these need to be in separate files? src/master/weights.hpp (line 60) <https://reviews.apache.org/r/43863/#comment182671> This fits on one line if you exclude variable names for the fields you don't use, e.g. ` Try<bool> perform(Registry* registry, hashset<SlaveID>*, bool);` src/master/weights.cpp (line 25) <https://reviews.apache.org/r/43863/#comment182672> Only indent 2 spaces - Adam B On Feb. 22, 2016, 6:18 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43863/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 6:18 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-4214 > https://issues.apache.org/jira/browse/MESOS-4214 > > > Repository: mesos > > > Description > ------- > > Move the implementation of updateWeights out of header. > > > Diffs > ----- > > src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a > src/Makefile.am 73e7ff06ba064c9b04f191009522d7808a7ab58e > src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d > src/master/master.cpp b453bc7fca05c192df616b7d80132985b3248547 > src/master/weights.hpp PRE-CREATION > src/master/weights.cpp PRE-CREATION > src/master/weights_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43863/diff/ > > > Testing > ------- > > make && make check successfully! > > > Thanks, > > Yongqiao Wang > >
