----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review121088 -----------------------------------------------------------
Patch looks great! Reviews applied: [41597, 41681, 43863] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 27, 2016, 12:43 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43863/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2016, 12:43 p.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Bugs: MESOS-4214 > https://issues.apache.org/jira/browse/MESOS-4214 > > > Repository: mesos > > > Description > ------- > > Move the implementation of updateWeights out of header. > > > Diffs > ----- > > src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e > src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 > src/master/master.hpp 13c6ff153e77c527822309e787942eb463d59e7d > src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 > src/master/weights.hpp PRE-CREATION > src/master/weights.cpp PRE-CREATION > src/master/weights_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43863/diff/ > > > Testing > ------- > > make && make check successfully! > > > Thanks, > > Yongqiao Wang > >
