----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121104 -----------------------------------------------------------
Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43905/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 7:17 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > `su` does not exist on Windows. Unfortunately, the launcher also depends > on it. In this commit, we remove Windows support for the launcher flag > `user`, which controls whether we use `su` in the launcher. This > allows us to divest ourselves of `su` altogether on Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > d917a99a46841156dc1e359c44010938cc45e943 > src/slave/containerizer/mesos/containerizer.cpp > 129406abdff715e321f683911e404c46676b6daf > src/slave/containerizer/mesos/launch.hpp > 7e29ca2b8bec1c20aef122472cff60f6003603ad > src/slave/containerizer/mesos/launch.cpp > 6b3bf163e2a577e6318a4a62f96d6bfd98ef9ae9 > > Diff: https://reviews.apache.org/r/43905/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
