> On Feb. 25, 2016, 5:47 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1207 > > <https://reviews.apache.org/r/43882/diff/5/?file=1270835#file1270835line1207> > > > > It seems a general functional class, can we move it into > > `process/metrics`?
I currently can only see a handful of uses of `process::metrics::Timer`, non of which would benefit from this helper yet. Let's pull it out once we see a general need. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review120718 ----------------------------------------------------------- On Feb. 28, 2016, 10:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43882/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 10:28 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4721 > https://issues.apache.org/jira/browse/MESOS-4721 > > > Repository: mesos > > > Description > ------- > > Added allocation metrics for allocation time. > > > Diffs > ----- > > docs/monitoring.md 827f7073204fcf8575ca980a5571c8be4f5e4110 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43882/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >