> On March 2, 2016, 7:28 a.m., Bernd Mathiske wrote: > > src/tests/mesos.hpp, line 135 > > <https://reviews.apache.org/r/43614/diff/1/?file=1251883#file1251883line135> > > > > So this injection is allowed to be a shared_ptr and the others are not? > > This makes me wonder if it would not be simpler if all injections were > > shared_ptr, even the ones that are sometimes Owned and sometimes not (i.e. > > declared with a parallel member of type *). Then we would only need one > > kind for all cases and a lot of code would look substantially simpler. The > > only Owned ones would be those that are always Owned.
I'll add a note above this one. The reason this is a `shared_ptr` is because the `Master` expects a `shared_ptr` for this one. Also see: https://reviews.apache.org/r/43613/#comment181352 - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121656 ----------------------------------------------------------- On Feb. 16, 2016, 2:15 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43614/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2016, 2:15 p.m.) > > > Review request for mesos, Bernd Mathiske and Artem Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Updates `StartMaster` and `StartSlave` test helpers to use the reworked > `cluster` helpers. Removes all `MesosTest` cleanup logic and as well as the > helpers that accept a `MockExecutor` pointer. > > > Diffs > ----- > > src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 > src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c > > Diff: https://reviews.apache.org/r/43614/diff/ > > > Testing > ------- > > Tests are run at the end of this review chain. > > > Thanks, > > Joseph Wu > >
