----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121855 -----------------------------------------------------------
LGTM, pending dependencies. - Bernd Mathiske On March 2, 2016, 1:45 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43614/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 1:45 p.m.) > > > Review request for mesos, Bernd Mathiske and Artem Harutyunyan. > > > Bugs: MESOS-4633 and MESOS-4634 > https://issues.apache.org/jira/browse/MESOS-4633 > https://issues.apache.org/jira/browse/MESOS-4634 > > > Repository: mesos > > > Description > ------- > > Updates `StartMaster` and `StartSlave` test helpers to use the reworked > `cluster` helpers. Removes all `MesosTest` cleanup logic and as well as the > helpers that accept a `MockExecutor` pointer. > > > Diffs > ----- > > src/tests/mesos.hpp 1d4f075e470a60040e17b9f011aea6202310c437 > src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c > > Diff: https://reviews.apache.org/r/43614/diff/ > > > Testing > ------- > > Tests are run at the end of this review chain. > > > Thanks, > > Joseph Wu > >