> On March 2, 2016, 11:37 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/metrics.hpp, line 43 > > <https://reviews.apache.org/r/44260/diff/1/?file=1276467#file1276467line43> > > > > Is it what clnag-format suggest? I doubt it : ) > > Benjamin Bannier wrote: > Yes, that's indeed what it suggests, at least with what is defined as > `Google` style in clang trunk.
We don't use Google style, but rather the one living in our source: https://mesos.apache.org/documentation/latest/clang-format/ - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/#review121624 ----------------------------------------------------------- On March 2, 2016, 5:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44260/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 5:49 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 24fa50f62dec10ed43089297473cc386d6ba2f78 > src/master/allocator/mesos/metrics.hpp PRE-CREATION > src/master/allocator/mesos/metrics.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44260/diff/ > > > Testing > ------- > > `make distcheck` on OS X. > > > Thanks, > > Benjamin Bannier > >
