----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44474/#review122401 -----------------------------------------------------------
src/master/master.cpp (line 6461) <https://reviews.apache.org/r/44474/#comment184371> Seems like we use post-increment elsewhere in this RR? src/master/metrics.cpp (line 327) <https://reviews.apache.org/r/44474/#comment184372> Why not use an iterator / foreach loop over `tasks_stats` instead? - Neil Conway On March 7, 2016, 10:51 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44474/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 10:51 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-4740 > https://issues.apache.org/jira/browse/MESOS-4740 > > > Repository: mesos > > > Description > ------- > > Avoid iterate the list of slaves, instead just maintain some counters. > > > Diffs > ----- > > src/master/master.hpp ea26670e6c6c67314406fded510e8fdd46053dc8 > src/master/master.cpp 57ff4a39039f573b8586bc03f873f97826b97f6f > src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 > src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 > > Diff: https://reviews.apache.org/r/44474/diff/ > > > Testing > ------- > > Manual check > > > Thanks, > > Cong Wang > >
