----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122572 -----------------------------------------------------------
Looks good, main thing is just to add some context to the installer script so that others understand why it exists. support/install-nvidia-gdk.sh (lines 1 - 2) <https://reviews.apache.org/r/44360/#comment184673> Could we pull down some of the content from the description into a block comment here? A few things that would be great to have: -What is the GDK? -Why do we include this installer script? -How to uninstall. -That apparently nvidia will stop publishing GDKs? We should check with Rob on that. Would be helpful also to mention why we tie this to a particular version. support/install-nvidia-gdk.sh (line 21) <https://reviews.apache.org/r/44360/#comment184679> Should this include the ldcache flag as well? support/install-nvidia-gdk.sh (line 89) <https://reviews.apache.org/r/44360/#comment184685> Can you check for errors on wget and make sure that it exits nicely? (e.g. test it out with a bad URL). support/install-nvidia-gdk.sh (line 95) <https://reviews.apache.org/r/44360/#comment184690> I probably wouldn't know what "invalid" means in this context. :) support/install-nvidia-gdk.sh (lines 99 - 100) <https://reviews.apache.org/r/44360/#comment184692> Maybe a little more context that nvidia's installer crashes when it encounters this file during re-installation? support/install-nvidia-gdk.sh (lines 102 - 104) <https://reviews.apache.org/r/44360/#comment184693> Maybe a small note about why we use `--silent` here? support/install-nvidia-gdk.sh (line 108) <https://reviews.apache.org/r/44360/#comment184676> Could we move this up to the top so that it's clearer that this is a side effect file after installation? - Ben Mahler On March 4, 2016, 1:21 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44360/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 1:21 a.m.) > > > Review request for mesos, Ben Mahler and Rob Todd. > > > Bugs: MESOS-4860 > https://issues.apache.org/jira/browse/MESOS-4860 > > > Repository: mesos > > > Description > ------- > > This script can be used to install the Nvidia GDK for Cuda 7.5 on a > mesos development machine. The purpose of the Nvidia GDK is to provide > all the necessary header files (nvml.h) and library files > (libnvidia-ml.so) necessary to build mesos with Nvidia GPU support. > > If the machine on which Mesos is being compiled doesn't have any GPUs, > then libnvidia-ml.so consists only of stubs, allowing Mesos to build > and run, but not actually do anything useful under the hood. This > enables us to build a GPU-enabled mesos on a development machine > without GPUs and then deploy it to a production machine with GPUs and > be reasonably sure it will work. > > The installation script itself takes a few parameters. > Run it as support/install-nvidia-gdk.sh --help to see its usage > semantics. > > > Diffs > ----- > > support/install-nvidia-gdk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/44360/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
