> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists.
Could you update the testing done so that others can tell how you tested this? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122572 ----------------------------------------------------------- On March 4, 2016, 1:21 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44360/ > ----------------------------------------------------------- > > (Updated March 4, 2016, 1:21 a.m.) > > > Review request for mesos, Ben Mahler and Rob Todd. > > > Bugs: MESOS-4860 > https://issues.apache.org/jira/browse/MESOS-4860 > > > Repository: mesos > > > Description > ------- > > This script can be used to install the Nvidia GDK for Cuda 7.5 on a > mesos development machine. The purpose of the Nvidia GDK is to provide > all the necessary header files (nvml.h) and library files > (libnvidia-ml.so) necessary to build mesos with Nvidia GPU support. > > If the machine on which Mesos is being compiled doesn't have any GPUs, > then libnvidia-ml.so consists only of stubs, allowing Mesos to build > and run, but not actually do anything useful under the hood. This > enables us to build a GPU-enabled mesos on a development machine > without GPUs and then deploy it to a production machine with GPUs and > be reasonably sure it will work. > > The installation script itself takes a few parameters. > Run it as support/install-nvidia-gdk.sh --help to see its usage > semantics. > > > Diffs > ----- > > support/install-nvidia-gdk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/44360/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >