----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123019 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 173) <https://reviews.apache.org/r/44672/#comment185153> From the docker code base they're checking against docker.io, not regsitry-1.docker.io, as I assume registry-1 is not a permanent name. I would suggest we don't hard code that as well. - Timothy Chen On March 10, 2016, 8:05 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44672/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 8:05 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added normalize method to registry puller. > > Logic is verified with docker go code > (https://github.com/docker/docker/blob/v1.10.2/reference/reference.go#L171~#L173). > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6d637ed14f35feb554c8fcc63a7a7e046aaca574 > > Diff: https://reviews.apache.org/r/44672/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh > --gtest_filter="*ProvisionerDockerRegistryPullerTest*" > > > Thanks, > > Gilbert Song > >
