> On 三月 19, 2016, 6:54 a.m., Shuai Lin wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 182 > > <https://reviews.apache.org/r/44672/diff/2/?file=1295109#file1295109line182> > > > > I would suggest to add a new test for the `normalize` function.
I think that the test was already covered in the followint patch here https://reviews.apache.org/r/44673/ - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124379 ----------------------------------------------------------- On 三月 14, 2016, 5:32 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44672/ > ----------------------------------------------------------- > > (Updated 三月 14, 2016, 5:32 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4877 > https://issues.apache.org/jira/browse/MESOS-4877 > > > Repository: mesos > > > Description > ------- > > Added normalize method to registry puller. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6d637ed14f35feb554c8fcc63a7a7e046aaca574 > > Diff: https://reviews.apache.org/r/44672/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh > --gtest_filter="*ProvisionerDockerRegistryPullerTest*" > > > Thanks, > > Gilbert Song > >
