> On March 10, 2016, 11:09 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 336-341 > > <https://reviews.apache.org/r/44531/diff/1/?file=1292300#file1292300line336> > > > > To be consistent, maybe just do `if (!ipAddressValue.isSome())` here as > > well?
For now I think I'll leave it as is since the depecreated API should always work for now, and therefore we don't expect errors. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review123025 ----------------------------------------------------------- On March 8, 2016, 10:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44531/ > ----------------------------------------------------------- > > (Updated March 8, 2016, 10:54 p.m.) > > > Review request for mesos, Dan Osborne, Jie Yu, and Travis Hegner. > > > Bugs: MESOS-4370 > https://issues.apache.org/jira/browse/MESOS-4370 > > > Repository: mesos > > > Description > ------- > > Fixed parsing network ip address with docker. > > > Diffs > ----- > > src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 > > Diff: https://reviews.apache.org/r/44531/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
