> On March 11, 2016, 4:22 p.m., Alexander Rojas wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines > > 54-61 > > <https://reviews.apache.org/r/44703/diff/2/?file=1296035#file1296035line54> > > > > s/"value:"/"value":/ > > > > also, the contents of value are free strings.
Ah yea, since the value has to be a string it looks a bit messy with a string representing a JSON array as its value. I think I still like the current format, since we'll be deprecating the space-delimited format. I changed the comments to include the JSON array in a string representation. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review123158 ----------------------------------------------------------- On March 11, 2016, 4:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44703/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 4:41 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added Doxygen docs for basic HTTP authenticator. > > The structure of the module parameters for the basic HTTP authenticator has > changed, so Doxygen comments were added to the module's header file to > provide an example. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > > Diff: https://reviews.apache.org/r/44703/diff/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
