> On March 18, 2016, 9:07 a.m., Adam B wrote: > > include/mesos/authentication/http/basic_authenticator_factory.hpp, lines > > 56-57 > > <https://reviews.apache.org/r/44703/diff/6/?file=1302915#file1302915line56> > > > > Why are these quotes escaped, but the others aren't? Because they're > > inside a string "value"? Seems odd.
Yep, it's because they're inside this JSON string. It's a bit messy, but necessary if the credentials are going to be specified as JSON. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124154 ----------------------------------------------------------- On March 18, 2016, 6:13 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44703/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 6:13 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added Doxygen docs for basic HTTP authenticator. > > The structure of the module parameters for the basic HTTP authenticator has > changed, so Doxygen comments were added to the module's header file to > provide an example. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > c11bb47c8e02f2e8645cf387d18eb64d1c8cb604 > > Diff: https://reviews.apache.org/r/44703/diff/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
