----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123176 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni.hpp (line 85) <https://reviews.apache.org/r/44514/#comment185359> I don't think we should have a hashmap within a hashmap. Hashmap are expensive in terms of memory. The outer hashmap makes sense since the isolator might need to manage hundreds of containers, but the inner hashmap is just a mapping from the network name to the result of attaching the container to that network, and most containers would joing a single network. Maybe just have a vector of strings (network names) here, and later, a vector of `NetworkResults` (once you introduce the protobuf) and name an `optional` field in the protobuf? src/slave/containerizer/mesos/isolators/network/cni.cpp (line 228) <https://reviews.apache.org/r/44514/#comment185356> Can there be a use case where you want multiple NICs to be attached to the same network? Servers use this configuration when they want to utilize NIC bonding. To aggregate the bandwidth available on the NICs src/slave/containerizer/mesos/isolators/network/cni.cpp (line 236) <https://reviews.apache.org/r/44514/#comment185357> If the CNI configuration is host-local then we will be calling the host-local plugin during `isolate`. So why do we need this? - Avinash sridharan On March 10, 2016, 2:20 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 2:20 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
