----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review123200 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni.hpp (line 85) <https://reviews.apache.org/r/44514/#comment185409> I would suggest we have a `Info` for each container. ``` struct Info { ... }; ``` Remember that for any field you put into the Info struct, you need to be able to 'recover' it in recover function. It's also possible that ExecutorInfo/TaskInfo are not available during recover (orphans due to wiped meta data). You need to think about how to recover (e.g., the name of the network) that the container has joined. - Jie Yu On March 10, 2016, 2:20 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 2:20 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
