----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123179 -----------------------------------------------------------
Can we introduce the protobuf before the `prepare` method patch? src/slave/containerizer/mesos/isolators/network/spec.proto (line 77) <https://reviews.apache.org/r/44622/#comment185360> Can we insert an optional `name` field here to keep track of the `Network` this result is for? This should not break the JSON schema. - Avinash sridharan On March 10, 2016, 3:29 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44622/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 3:29 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkResult". > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44622/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >