> On March 21, 2016, 2:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > <https://reviews.apache.org/r/44622/diff/4/?file=1302264#file1302264line17> > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: > Jie, did you mean putting it under mesos.internal.slave.cni.spec or under > cni.spec? If what you mean is the latter, then I think we may also move this > `spec.proto` file to another place, e.g., under `include/mesos/cni`, just > like what we did for the spec.proto of Docker and Appc. Agree? :-)
sorry, i meant the former (under meaos.internal.slave) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review124484 ----------------------------------------------------------- On March 17, 2016, 10:06 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44622/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 10:06 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Introduced a protobuf message "NetworkResult". > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/44622/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
