> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 48 > > <https://reviews.apache.org/r/44555/diff/1/?file=1293049#file1293049line48> > > > > Let's remove this 'empty' check here since you hae the os::exists check > > below. > > Qian Zhang wrote: > They are for different purposes, `os::exist` is used to check if the > directory exists or not, and here > `flags.network_cni_plugins_dir.get().empty()` is used to check if operator > does not specify the value of `--network_cni_plugins_dir` (e.g., > "`--network_cni_plugins_dir=`") when starting agent.
ok, can you use flags.network_ci_plugin_dir->empty()? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123192 ----------------------------------------------------------- On March 15, 2016, 3:02 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44555/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 3:02 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented the framework and create() method of "network/cni" isolator. > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 7ee5a653fc96907021f14ab28f74c0b3ed0649d9 > src/slave/containerizer/mesos/isolators/network/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44555/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
