----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123973 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 91) <https://reviews.apache.org/r/44555/#comment186318> let's use networkConfig here to be consistent. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 65) <https://reviews.apache.org/r/44555/#comment186319> you can use ->empty() without 'get()' src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 70) <https://reviews.apache.org/r/44555/#comment186320> Ditto. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 104) <https://reviews.apache.org/r/44555/#comment186322> s/netConfig/networkConfig/ src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 127) <https://reviews.apache.org/r/44555/#comment186321> s/netConfig/networkConfig/ - Jie Yu On March 16, 2016, 7:25 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44555/ > ----------------------------------------------------------- > > (Updated March 16, 2016, 7:25 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented the framework and create() method of "network/cni" isolator. > > > Diffs > ----- > > src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44555/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
