> On March 18, 2016, 9:33 p.m., Ben Mahler wrote: > > The change looks good but please add a test for this. > > > > Ideally there could be a stateless validateExecutorInfo, in addition to the > > one that needs the master state. In the absence of this, you can write a > > test that spins up a framework and launches a task with a negative shutdown > > duration. > > Ben Mahler wrote: > I see now that you tested this in https://reviews.apache.org/r/44994/ > inside a larger test, would have been helpful to mention that here since the > testing done section points to https://reviews.apache.org/r/44662 which seems > to be only a CHANGELOG change..?
I suggested on https://reviews.apache.org/r/44994/ that we pull out a smaller test for the validation and place it inside `master_validation_tests.cpp` to be more consistent. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review124290 ----------------------------------------------------------- On March 17, 2016, 11:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44854/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 11:34 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4949 > https://issues.apache.org/jira/browse/MESOS-4949 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44854/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
